Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Latest issued Vaccination DCC 2/2 does not have highest priority (EXPOSUREAPP-8756) #4123

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 26, 2021

  • Find latest Vaccination certificate by vaccinatedOn and issuedAt dates

Ticket

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-8756

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Sep 26, 2021

@mtwalli

I've verified the fix on Android 8 with an older and a new 2/2 vaccination certificate.

This looks good! 👍🏻

Steps to verify

  1. Clean install CWA deviceForTestersDebug 2.11.0-RC2
  2. Complete onboarding
  3. Tap "Certificates" tab, tap "CONTINUE"
  4. Tap "+ CERTIFICATE" and scan an older complete EU Digital COVID Vaccination Certificate e.g. Number in a series of vaccinations/doses 2/2
  5. Scroll down to Zertifikatkennung / Unique Certificate Identifier and make a note of the last few characters of the identifier
  6. Tap back arrow
  7. Tap "+ CERTIFICATE" and scan an a re-issued complete EU Digital COVID Vaccination Certificate e.g. Number in a series of vaccinations/doses 2/2 for the same person and the same vaccination date as in step 4
  8. Tap right arrow
  9. Scroll down to "Currently used certificate" and tap on it
  10. Note that the Unique Certificate Identifier is from the older certificate scanned in first. 🙁

Now with the fix applied

  1. Update to CWA from branch fix/8756-order-by-issued-at
  2. Tap "Certificates" tab
  3. Tap right arrow
  4. Scroll down to "Currently used certificate" and tap on it
  5. Note that the Unique Certificate Identifier is from the newer certificate scanned in second. 🚀 😄

@mtwalli mtwalli added the prio PRs to review first. label Sep 27, 2021
@jurajkusnier jurajkusnier self-assigned this Sep 27, 2021
@SamuraiKek SamuraiKek self-assigned this Sep 27, 2021
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
4 participants