-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace -h with value provided by MemoryMXBean #76
Conversation
Hello! Thank you for this contribution. The change to detect compressed oops configuration looks good. However, I believe the intent with heap size (-h) was that it represent the maximum heap size (see description of constructor parameter). For this reason, I believe we want This change will also break the tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix related tests in SimpleRunConfigTest.
I'll take a look at the security manager issues at the same time as fixing the max heap issue. |
all of the tests aside from the security manager should be functional now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the tests and this contribution!
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.