Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add option to dump genesis files in E2E tests #6100
tests: add option to dump genesis files in E2E tests #6100
Changes from 22 commits
65a41e2
c6266ac
9899bf4
7f44b73
a324846
f55d53f
f8f097b
934e2f0
fe24e23
8434b70
8a02d35
b9d9841
3a78f8c
06795b2
1cd3073
64b98a6
c8cc6b3
a46ca74
d37b961
3fb3d57
0261a22
63db86c
a6a6322
ecd0186
7d4b8d5
e6f5512
7c16d6b
495964b
d39df3b
ed2fcc9
c1a77c5
d6bbd8e
eba5cbc
35e3f74
e303ca0
c199f76
0846468
f70c7d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why an alias was chosen here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch and yes! The reason is that at line 175 we have a function that uses a variable named path, and this made the linter sad :(
Of course, now that I think about it, I could have easily just changed the variable instead, which is probably cleaner. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No super strong opinion but I'd go with changing the var name personally. Prefer to keep the stdlib imports as unaliased as possible 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this basically means we'll run these per test yea? Is this expected behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, basically just a way to make sure that env vars get set for each specific test based on the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking now, I think we can make this unexported actually, should never have as need for this outside of this testsuite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a link to interchaintest code for where this is used