chore: rename channel to channel end in v2 #7515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal and
chatton
as code owners
bznein
reviewed
Oct 25, 2024
| func NewChannel(clientID, counterpartyChannelID string, merklePathPrefix commitmenttypes.MerklePath) Channel { | ||
| return Channel{ | ||
| // NewChannel creates a new ChannelEnd instance | ||
| func NewChannel(clientID, counterpartyChannelID string, merklePathPrefix commitmenttypes.MerklePath) ChannelEnd { |
There was a problem hiding this comment.
Should we rename this to NewChannelEnd too?
| @@ -34,8 +34,8 @@ message QueryChannelRequest { | |||
|
|
|||
| // QueryChannelRequest is the response type for the Query/Channel RPC method | |||
| message QueryChannelResponse { | |||
There was a problem hiding this comment.
Q: how deep with the renaming do we want to go? Could this be called QueryChannelEndResponse (and the same for all the others?)
Do we want to rename params in functions from channel to channelEnd?
|
On second thought maybe we should just leave this called
I'll close and if we want to go back to this we can resurect it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.