Add standard img tag attribute support. #353
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this tool I came across the need to use the
srcset
attribute on myimg
tag but found that the attribute was being applied to the figure instead of the img tag. This change should add support for all standard img tag attibutes so they go where they belong.Example:
Should output as:
This is my first attempt at modifying code on this project so please feel free to provide corrections or request adjustments. I'm not really familiar with TypeScript so I didn't modify that part and was unsure if I needed to.
Ohhh and the prettier mod was to remove some line ending issue I was seeing (similar to: https://stackoverflow.com/questions/53516594/why-do-i-keep-getting-delete-cr-prettier-prettier). I use Windows for dev, I'm guessing you use Mac. Let me know if it causes issues on your end. 😄