Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocl: fixes and improvements #728

Merged
merged 1 commit into from
Oct 26, 2023
Merged

ocl: fixes and improvements #728

merged 1 commit into from
Oct 26, 2023

Conversation

hfp
Copy link
Member

@hfp hfp commented Oct 26, 2023

  • tune_multiply.py

    • Save good intermediate results after an earlier kernel failed.
    • Fixed potential type-conversion error.
    • Improved error message.

  • SMM-kernel

    • Repurposed 1<LU, and improved code-path using general blocks.
    • Folded some explicit control-flow into loop-condition.
    • Use 32-bit integer variables consistently.
    • Removed superfluous casts.
    • Improved comments.

@hfp
ocl: fixes and improvements
6d5b798 
* tune_multiply.py
  - Save good intermediate results after an earlier kernel failed.
  - Fixed potential type-conversion error.
  - Improved error message.

* SMM-kernel
  - Repurposed 1<LU, and improved code-path using general blocks.
  - Folded some explicit control-flow into loop-condition.
  - Use 32-bit integer variables consistently.
  - Removed superfluous casts.
  - Improved comments.
@hfp hfp merged commit 87ff3c8 into cp2k:develop Oct 26, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hfp