ocl: adjusted finalization-flow of OpenCL backend #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hfp
commented
Mar 6, 2024
hfp
commented
- Fixed case when ACC_OPENCL_MEM_DEVPTR is turned off at compile-time.
- Ensure termination message appears one time at most (cleanup).
- Introduced ACC_OPENCL_EVENT_CHAIN and ACC_OPENCL_EVENT_WAIT.
- Removed compile-time option for ACC_OPENCL_MEM_CPYSYNC.
- Removed compile-time setting (ACC_OPENCL_STREAM_NULL).
- Introduced WA-levels to distinct certain WAs.
- Ensure final cleanup (atexit).
* Fixed case when ACC_OPENCL_MEM_DEVPTR is turned off at compile-time. * Ensure termination message appears one time at most (cleanup). * Introduced ACC_OPENCL_EVENT_CHAIN and ACC_OPENCL_EVENT_WAIT. * Removed compile-time option for ACC_OPENCL_MEM_CPYSYNC. * Removed compile-time setting (ACC_OPENCL_STREAM_NULL). * Introduced WA-levels to distinct certain WAs. * Ensure final cleanup (atexit).
|
For the merged PR, the precommit tests are apparently failing while it they were green locally as well as for the PR prior to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.