Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JUnitReporter #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor JUnitReporter #367

wants to merge 2 commits into from

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Jan 27, 2025

Changes

  • Pass parsed CaptureGroup instead of raw xcodebuild output. This avoids duplicate parsing and better leverages type safety.
  • Consolidate JUnitComponent parsing, avoiding the need for duplicate instantiation and optionals.
  • Fix typos.

Testing

Validated that sample XCTest input parsed as a JUnit report using the debug executable.

@cpisciotta cpisciotta marked this pull request as ready for review January 27, 2025 00:15
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (de4629e) to head (2940ca7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   90.16%   89.71%   -0.46%     
==========================================
  Files          17       17              
  Lines        2470     2459      -11     
==========================================
- Hits         2227     2206      -21     
- Misses        243      253      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta force-pushed the charles/JUnit branch 4 times, most recently from 45669d4 to 6cfbb6d Compare February 1, 2025 22:56
@cpisciotta cpisciotta force-pushed the charles/JUnit branch 2 times, most recently from 2940ca7 to 5a96440 Compare February 2, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant