Skip to content

Commit

Permalink
Test everything
Browse files Browse the repository at this point in the history
  • Loading branch information
TejasQ committed Nov 16, 2023
1 parent 59d389f commit adb6c9b
Show file tree
Hide file tree
Showing 16 changed files with 347 additions and 83 deletions.
3 changes: 2 additions & 1 deletion web-client/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ dist-ssr
src/lib/proto/*

# Except for the README.md file
!src/lib/proto/README.md
!src/lib/proto/README.md
coverage
3 changes: 2 additions & 1 deletion web-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"format": "prettier --write .",
"lint": "eslint . --ext .ts,.tsx",
"lint:fix": "eslint . --fix --ext .ts,.tsx",
"test": "pnpm proto && vitest"
"test": "TZ=UTC pnpm proto && vitest"
},
"devDependencies": {
"@protobuf-ts/protoc": "^2.9.1",
Expand All @@ -23,6 +23,7 @@
"@types/testing-library__jest-dom": "^5.14.9",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"@vitest/coverage-v8": "^0.34.6",
"autoprefixer": "^10.4.16",
"eslint": "^8.53.0",
"eslint-config-prettier": "^8.10.0",
Expand Down
100 changes: 100 additions & 0 deletions web-client/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion web-client/src/lib/formatters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function convertTimestampToNanoseconds(timestamp: Timestamp): number {
return (Number(timestamp.seconds) * 1e9) + (timestamp.nanos);
}

function formatMs(ms: string) {
export function formatMs(ms: string) {
switch (ms.length) {
case 1:
return "00" + ms;
Expand All @@ -18,6 +18,7 @@ function formatMs(ms: string) {
return ms;
}
}

export function formatTimestamp(stamp: Date) {
return `${stamp.toLocaleTimeString("en", {
hour: "2-digit",
Expand Down
15 changes: 15 additions & 0 deletions web-client/src/lib/span/a.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { Span } from "../connection/monitor";
import { Metadata } from "../proto/common";
import { flattenChildren } from "./flattenChildren";

type Options = { span: Span, metadata: Map<bigint, Metadata> }

export function recursivelyFindSpanByName({ span, metadata }: Options, name: string): Span[] | null {
const meta = metadata.get(span.metadataId)!;
if (meta.name === name) {
return [span];
}

const allChildren = flattenChildren(span.children);
return allChildren?.filter(c => metadata.get(c.metadataId)!.name === name) ?? null;
}
19 changes: 0 additions & 19 deletions web-client/src/lib/span/findSpanByName.ts

This file was deleted.

12 changes: 6 additions & 6 deletions web-client/src/lib/span/getIpcRequestName.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import { Span } from "../connection/monitor";
import { Metadata } from "../proto/common";
import { findSpanByName } from "./findSpanByName";
import { recursivelyFindSpanByName } from "./recursivelyFindSpanByName";

type Options = {
metadata: Map<bigint, Metadata>
span: Span
}

export function getIpcRequestName({ metadata, span }: Options) {
const meta = metadata.get(span.metadataId)!;
if (meta.name === "wry::ipc::handle") {
const commandHandlerSpan = findSpanByName(
const meta = metadata.get(span.metadataId);
if (meta?.name === "wry::ipc::handle") {
const commandHandlerSpan = recursivelyFindSpanByName(
{ span, metadata },
"ipc::request::handle"
);
)?.[0] ?? null;
if (commandHandlerSpan) {
const val = commandHandlerSpan.fields.find(
(f) => f.name === "cmd"
Expand All @@ -22,5 +22,5 @@ export function getIpcRequestName({ metadata, span }: Options) {
return val?.oneofKind === "strVal" ? val.strVal : null;
}
}
return meta.name;
return meta?.name ?? null;
};
4 changes: 2 additions & 2 deletions web-client/src/lib/span/recursivelyFindSpanByName.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { flattenChildren } from "./flattenChildren";
type Options = { span: Span, metadata: Map<bigint, Metadata> }

export function recursivelyFindSpanByName({ span, metadata }: Options, name: string): Span[] | null {
const meta = metadata.get(span.metadataId)!;
if (meta.name === name) {
const meta = metadata.get(span.metadataId);
if (meta?.name === name) {
return [span];
}

Expand Down
Loading

0 comments on commit adb6c9b

Please sign in to comment.