Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle forward slash path in Windows #13

Merged
merged 3 commits into from
Dec 7, 2023
Merged

fix: Handle forward slash path in Windows #13

merged 3 commits into from
Dec 7, 2023

Conversation

tekai-crabnebula
Copy link
Contributor

@FabianLars-crabnebula
Copy link
Member

Seeing that \\?\ is also stripped i'd suggest to seriously consider using dunce's canonicalize function.

@lucasfernog-crabnebula lucasfernog-crabnebula merged commit 0e18b08 into crabnebula-dev:main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars-crabnebula FabianLars-crabnebula FabianLars-crabnebula approved these changes

@lucasfernog-crabnebula lucasfernog-crabnebula Awaiting requested review from lucasfernog-crabnebula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekai-crabnebula @FabianLars-crabnebula @lucasfernog-crabnebula