Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(macos): implement data drag e.g. FCPXML #19

Merged
merged 4 commits into from
Dec 18, 2023
Merged

feat(macos): implement data drag e.g. FCPXML #19

merged 4 commits into from
Dec 18, 2023

Conversation

lucasfernog-crabnebula
Copy link
Member

No description provided.

@denjell-crabnebula
Copy link
Contributor

denjell-crabnebula commented Dec 12, 2023 •
edited
Loading

This can be a helpful resource

As well as this perhaps:
https://developer.apple.com/documentation/appkit/drag_and_drop

@lucasfernog-crabnebula lucasfernog-crabnebula marked this pull request as ready for review December 12, 2023 12:09
@jason-crabnebula
Copy link
Contributor

Hmm.. do we need to autorelease those manually allocated objects?

@lucasfernog-crabnebula
Copy link
Member Author

You mean NSData? I just copied it from wry which is working. freeWhenDone should take care of it.

@lucasfernog-crabnebula lucasfernog-crabnebula merged commit 44c91f8 into main Dec 18, 2023
9 checks passed
@lucasfernog-crabnebula lucasfernog-crabnebula deleted the feat/drag-data branch December 18, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-crabnebula jason-crabnebula jason-crabnebula approved these changes

@Wu-Yu-Wei Wu-Yu-Wei Awaiting requested review from Wu-Yu-Wei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfernog-crabnebula @denjell-crabnebula @jason-crabnebula