Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter issues #2173

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix linter issues #2173

merged 4 commits into from
Jan 7, 2025

Conversation

crankyoldgit
Copy link
Owner

The continuous build appears to be using a new linter.
Address most of the issues it is complaining about.
No fundamental code changes.

@crankyoldgit crankyoldgit self-assigned this Jan 7, 2025
@crankyoldgit crankyoldgit requested a review from NiKiZe January 7, 2025 07:28
NiKiZe
NiKiZe approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@NiKiZe NiKiZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these changes does seem odd that we need to do, but can't be helped.

@crankyoldgit crankyoldgit merged commit 3390e72 into master Jan 7, 2025
46 checks passed
@crankyoldgit crankyoldgit deleted the FixLinterIssues branch January 7, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @NiKiZe