-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gaufrette storage #353
base: master
Are you sure you want to change the base?
Conversation
This is due some Gaufrette adapters like AWS S3 adapter cannot be serialized.
Don't use file extension on gaufrette tmp file
…ts replaced on data array
Really cool. I like it but I would rather make it one more level of abstraction. This will make possible also to use FlySystem for storage. And it will also remove the hard dependency of Gaufrette. Something like BlobStorage interface and pass concrete implementation to DataManager. Current implementation of file storage can be also moved to SessionBlobStorage implementation for example. This will save the many if - else and make the code looks cleaner. |
@kevincerro @Warxcell @craue Nice feature. I use Gaufrette to store images on AWS because my PAAS does not have a filesystem. |
I see a lot of work went into this already. And basically, I also like the idea of being able to save files in different ways. But @Warxcell has a good point on abstraction. Adding adapters for soft dependencies to various libraries would be nice. Tests would be needed as well. Anyone up for working on this? @kevincerro, are you in the mood to resume? |
This adds Gaufrette support to handle file uploads.
Some improvements can be made, feel free to suggest any necessary changes.
Solves #316