Use the new trait solver. #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xldenis
reviewed
Nov 13, 2024
xldenis
reviewed
Nov 13, 2024
|
Oh, and by the way: this PR magically fixes our problem with |
Magical fixes are the best kinds of fixes |
… avoid some normalization in term.rs and vcgen.rs.
jhjourdan
force-pushed
the
new_trait_solver
branch
from
71628f3 to
89e6bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will nee too do that anyway, and this may help for #1232.
The main issue I encountered is that the new trait solver does not allow ambiguity between a user impl and an impl coming from ParamEnv when searching for an instance. This is fixed by removing all such ambiguities in our code base. At some point, we will need to figure out a way to report a pleasant error message when finding trait method instances fails because of such an ambiguity.