change the deep model of Box<T> to Box<T::DeepModelTy> #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the usage of the derive macro on recursive types. It's absolutely essential that this functions, as for 99% of people deep model should be transparent. I already think that imposing a derive macro quasi-systeatically is already tedious. However, this also suggests that we should change the deep models for other pointer types like
Rc
orArc
to beBox<T::DeepModel>
as well, which, I'm not sure how I feel about that. Finally, I've been thinking we might want to renameDeepModel
toEqModel
or something which more clearly relates its purpose.