Non Prusti specific changes that are helpful for adding Prusi-ish syntax #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xldenis
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
I modified the types stored in pearlite Terms so that they match the types from THIR, instead of stripping off boxes and shared references.
This is something I wanted to do anyways it makes the interpretation of terms well founded.
I think the creusot_ty method is good but longer term I'd like tens to be fully well typed and not elude those references.
|
|
||
| #[cfg(not(creusot))] | ||
| extern crate creusot_contracts_dummy as base_macros; |
|
Sorry, when you approve changes do you mean for me to merge them, or do you prefer to do that yourself? |
|
No go ahead and merge yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #932 you mentioned it would be useful to extract out some of the changes I made that are not Prusti specific into there own PR.
I reorganized
creusot_contractsaddingbase_macroswhich is just a re-export of eithercreusot_contracts_procorcreusot_contracts_dummy, andpreludewhich re-exports the items fromcreusot_contractsbut not all the modules so that you canuse creusot_contracts::prelude::*instead ofuse creusot_contracts::*.I modified the types stored in pearlite
Terms so that they match the types from THIR, instead of stripping off boxes and shared references. I also added acreusot_tymethod that returns the type with boxes and shared references removed to use in places creusot was relying on this stripping.