Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwhub: context type #2631

Merged
merged 8 commits into from
Dec 7, 2023
Merged

cwhub: context type #2631

merged 8 commits into from
Dec 7, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 30, 2023

This support for items of type "context" in the hub, and is intended to replace the directory approach in #2498

  • add expr helpers
  • remove command "lapi context delete" to avoid ambiguity (the status command shows content from hub + console/context.yaml)

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (3e86f52) 54.76% compared to head (7a3d48f) 54.92%.

❗ Current head 7a3d48f differs from pull request most recent head e046123. Consider uploading reports for the commit e046123 to get more accurate results

Files Patch % Lines
cmd/crowdsec-cli/lapi.go 24.07% 37 Missing and 4 partials ⚠️
pkg/alertcontext/config.go 80.00% 10 Missing and 5 partials ⚠️
pkg/cwhub/item.go 0.00% 7 Missing and 2 partials ⚠️
pkg/csconfig/crowdsec_service.go 25.00% 5 Missing and 1 partial ⚠️
pkg/alertcontext/alertcontext.go 57.14% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/support.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
+ Coverage   54.76%   54.92%   +0.16%     
==========================================
  Files         222      224       +2     
  Lines       29692    29782      +90     
==========================================
+ Hits        16260    16357      +97     
- Misses      11834    11835       +1     
+ Partials     1598     1590       -8     
Flag Coverage Δ
bats 36.26% <61.34%> (+0.24%) ⬆️
unit-linux 49.63% <7.00%> (-0.21%) ⬇️
unit-windows 47.74% <7.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Nov 30, 2023
@mmetc mmetc force-pushed the hub-1.5.6 branch 4 times, most recently from 9418f2e to 846a7da Compare December 5, 2023 12:46
@mmetc mmetc added this to the 1.5.6 milestone Dec 5, 2023
@mmetc mmetc force-pushed the hub-1.5.6 branch 4 times, most recently from 53b59f6 to 2bf2bfc Compare December 6, 2023 15:13
@mmetc mmetc marked this pull request as ready for review December 7, 2023 11:37
}

},
Deprecated: "please manually edit the context file.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we show to the user where is this file ?

@mmetc mmetc merged commit 4acb4f8 into master Dec 7, 2023
11 checks passed
@mmetc mmetc deleted the hub-1.5.6 branch December 7, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants