Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing auth id(0x02~0x05) #2

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

XuJiandong
Copy link
Contributor

@XuJiandong XuJiandong commented Jan 12, 2024

Migrate PR from: nervosnetwork/ckb-production-scripts#75
The binary remains same after migration.

Main Changes

Add auth algorithm ids for following blockchains:

  • bitcoin(Support UniSat and OKX wallet)
  • tron
  • dogecoin
  • new ethereum with signing message with prefix

Special feature for BTC/EtH, now they can display meaningful messages like below:

  • btc(unisat/okx)
You're signing:
CKB (Bitcoin Layer) transaction: 0x{sighash_all in hex}
image
  • eth(metamask)
You're signing:
CKB transaction: 0x{sighash_all in hex}
image

Other changes:

  • Add hash functions: sha256 and ripemd160
  • Fix rust toolchains
  • Code format

migrate PR from: nervosnetwork/ckb-production-scripts#75

including
* eos
* tron
* bitcoin(Support UniSat and OKX wallet)
* dogecoin

Special feature for btc/etc, now they can display meaningful messages.

* BTC(UniSat/OKX)
You're signing:
CKB (Bitcoin Layer-2) transaction: 0x{sighash_all in hex}

* ETH(Metamask)
You're signing:
CKB transaction: 0x{sighash_all in hex}
@homura
Copy link

homura commented Jan 22, 2024

It would be helpful to include the compiled binary in this PR and keep it updated.

update:
omni_lock_9419b77.zip

@XuJiandong XuJiandong merged commit cd764d7 into cryptape:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants