Problem: release/v0.1 branch is not updated with latest code
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Problem: Dependencies are not upgraded to latest Solution: Upgraded dependencies and fixed clippy warnings * Fix ethermint build failure * Add missing import * upgrade dependencies * bump up versions of crate to 0.1.2
tomtau
reviewed
May 17, 2022
tomtau
approved these changes
Jun 6, 2022
signers/mnemonic-signer/src/lib.rs
Outdated
| @@ -107,11 +106,14 @@ impl Signer for MnemonicSigner { | |||
| let signing_key = self.get_signing_key()?; | |||
|
|
|||
| let signature: Signature = match self.algo { | |||
| AddressAlgo::Secp256k1 => signing_key.sign_digest(sha2::Sha256::new().chain(message)), | |||
| AddressAlgo::Secp256k1 => <SigningKey as k256::ecdsa::signature::Signer< | |||
There was a problem hiding this comment.
&signing_key.sign(...) won't infer correctly?
| let encoded_point: EncodedPoint = key.into(); | ||
| let hash = | ||
| Keccak256::digest(&encoded_point.to_untagged_bytes().unwrap())[12..].to_vec(); | ||
| let encoded_point: EncodedPoint = key.to_encoded_point(false); |
There was a problem hiding this comment.
false here is for uncompressed (maybe good to add a comment)
Solution: Update LICENSE file
* Problem: License file is not up-to-dated Solution: Update LICENSE file * Problem: Copyright is missing attribution Solution: Update LICENSE file * Removed double comment openings
* Problem: License file is not up-to-dated Solution: Update LICENSE file * Problem: Copyright is missing attribution Solution: Update LICENSE file * Removed double comment openings * Problem: Copyright entity has to be updated Solution: Update files with copyright notice
* Upgrade ibc-go and cosmos-sdk to latest version * Update github workflows and fix clippy errors * update audit check github action * Fix path string encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Merge
mainbranch intorelease/v0.1.