Add node to CallType #2547
Closed
Add node to CallType #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make this a new API or consider it a breaking change? |
|
I think it's fine to consider it a breaking change. This API is not used in a lot of places which i should have already changed them in this PR, i don't expect third party scripts to use this API and in any case the change to be made is really simple. For simplicity i kept the same *CallType also in the Node which with the addition of the node it's expected to be a redundant information. I also did not check for places where this new API could be used to optimize the process instead of iterating all the nodes as it's probably done right now, it can be for another PR if we decide to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.