Cw2 10 redesign resources cards to incorporate logos #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CW2-29 Create additional resource for CSESoc Learn
derekxu04
requested changes
Jun 23, 2024
There was a problem hiding this comment.
Really nice work, looks much better now.
Changes:
- Put some small comments below
- Make sure to pull from the
mainbranch, as there have been some changes. One main one is that Compclub has been replaced with CSESoc Learn, but hopefully that is a very quick fix
Comments:
- I think the grid format is fine if we did want to keep it, but did you have any suggestions, would be more than happy to hear them
| <h2 className="mt-1 text-3xl font-extrabold">Enrolment Guide</h2> | ||
| <p className="mt-7 text-lg mb-5">Learn how to get a headstart on uni</p> | ||
| </a> | ||
| {stage1.map((item, index) => { |
There was a problem hiding this comment.
nit: don't need index if not going to use it, can just do .map(item => {...})
| </a> | ||
| {stage1.map((item, index) => { | ||
| return ( | ||
| <a |
There was a problem hiding this comment.
need a key for each element otherwise will complain
…https://github.com/csesoc/csesoc-website-2023 into CW2-10-redesign-resources-cards-to-incorporate-logos
derekxu04
approved these changes
Jun 24, 2024
| <h2 className="mt-1 text-3xl font-extrabold">Enrolment Guide</h2> | ||
| <p className="mt-7 text-lg mb-5">Learn how to get a headstart on uni</p> | ||
| </a> | ||
| {stage1.map((item: any) => { |
There was a problem hiding this comment.
Should be item: resourceCards right
package-lock.json
Outdated
There was a problem hiding this comment.
I think this is left over from before we moved into frontend/backend, can remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes are required?
As specified in title.
Changes
Screenshots
Comments