Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CW2-33] Organise Landing Page #19

Merged
merged 20 commits into from
Jul 4, 2024
Merged

Conversation

QuadAces
Copy link
Collaborator

Why the changes are required?

To clean up the landing page

Changes

  • Completely removed the stats card
  • Added a short paragraph/list about what CSE soc does (summarised from Linkedin)
  • Resources completely cut (and sponsors number changed from 04 to 03 on the UI) as the component is already displayed on the resources page and can be accessed via the navbar/HB menu

Screenshots

Screenshot 2024-06-27 at 3 05 36 am Screenshot 2024-06-27 at 3 05 54 am Screenshot 2024-06-27 at 3 06 14 am Screenshot 2024-06-27 at 3 06 26 am

Comments

  • No complains here, very good decision. I did like the aesthetic of many of these components and also I definitely think its a hard but smart and correct decision to remove them from the homescreen. Would suggest considering reusing the components somewhere else perhaps.

@derekxu04 derekxu04 self-requested a review June 27, 2024 08:11
Copy link
Collaborator

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nice work.

Ok a few things

  • I think the numbers for each section on the landing page, but not so much the navbar / each of the pages. So: remove the numbers from the navbar + the pages associated with them, probably make the text bigger and closer together
  • I think the About section is too much text, I am not too sure what I want to put instead, can start by putting maybe just a few sentences next to the logo idk (this component will be moved to the /about page)
  • I think buttons linking to the relevant pages would be good (e.g. "Learn more" after the about part, "See all events" for the events page)

@QuadAces QuadAces requested a review from derekxu04 June 27, 2024 12:21
Copy link
Collaborator

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Haven't deleted the numbers for resources and contact us.
  • For the about section on the landing page, I think using the entire component is too much. I think get rid of the pinned section (but don't change the original component since we need it for the about section), instead of writing out the full content, have text in the README like "Learn more" or something that directs to /about. In line with this, can get rid of some of the stuff on the left to make it even
  • "See all events" button should not stretch over that much

frontend/src/components/Event/index.tsx Show resolved Hide resolved
@derekxu04
Copy link
Collaborator

I think we should still change up the about section for the landing page, maybe remove the entire README concept, but I'm happy to merge this now and then assign a new ticket for the about section

@derekxu04 derekxu04 self-requested a review July 4, 2024 07:10
Copy link
Collaborator

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekxu04 derekxu04 merged commit 5fa1c38 into master Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants