-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CW2-33] Organise Landing Page #19
Conversation
…exactly the same component at ./resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok nice work.
Ok a few things
- I think the numbers for each section on the landing page, but not so much the navbar / each of the pages. So: remove the numbers from the navbar + the pages associated with them, probably make the text bigger and closer together
- I think the About section is too much text, I am not too sure what I want to put instead, can start by putting maybe just a few sentences next to the logo idk (this component will be moved to the
/about
page) - I think buttons linking to the relevant pages would be good (e.g. "Learn more" after the about part, "See all events" for the events page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Haven't deleted the numbers for resources and contact us.
- For the about section on the landing page, I think using the entire component is too much. I think get rid of the pinned section (but don't change the original component since we need it for the about section), instead of writing out the full content, have text in the README like "Learn more" or something that directs to /about. In line with this, can get rid of some of the stuff on the left to make it even
- "See all events" button should not stretch over that much
I think we should still change up the about section for the landing page, maybe remove the entire README concept, but I'm happy to merge this now and then assign a new ticket for the about section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Why the changes are required?
To clean up the landing page
Changes
Screenshots
Comments