Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CW2-46] redesign about section on landing page #33

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

andrew-l3
Copy link
Collaborator

Why the changes are required?

Per spec

Changes

  • UI changes (as shown); building on previous items.
  • Stats and other metrics require changing.
  • Design made to match github stats as requested, however further recommendations can be made.

Screenshots

screen 1
screen

Comments

@Domin0de Domin0de changed the title Cw2 46 redesign about section on landing page [CW2-46] redesign about section on landing page Oct 11, 2024
@Domin0de
Copy link
Member

That looks good, just a few quick points:

  • Is there a particular reason why the "Events held", "Subcom", etc under the statistics section are clickable, whilst events held is the only one which highlights?
  • Potentially make the information within the ".md" sections slightly darker or play around with some other way of making a clear distinction between the code line numbers and the text?

@derekxu04
Copy link
Collaborator

(would be good to find a way to take up the whole vertical page, but couldn't think of anything)
image

@derekxu04 derekxu04 requested a review from Domin0de October 18, 2024 08:12
@Domin0de Domin0de merged commit a192064 into master Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants