Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Add separate ungrouped_scan flag to wrapper replacer context #9120

Merged
merged 3 commits into from
Jan 28, 2025

fix(cubesql): Depend on a proper flag for grouped join part

733cca0
Select commit
Loading
Failed to load commit list.
Merged

feat(cubesql): Add separate ungrouped_scan flag to wrapper replacer context #9120

fix(cubesql): Depend on a proper flag for grouped join part
733cca0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 27, 2025 in 1s

97.89% of diff hit (target 83.07%)

View this Pull Request on Codecov

97.89% of diff hit (target 83.07%)

Annotations

Check warning on line 118 in rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/cube_scan_wrapper.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/cube_scan_wrapper.rs#L118 

Added line #L118 was not covered by tests

Check warning on line 508 in rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/filter.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/filter.rs#L508 

Added line #L508 was not covered by tests

Check warning on line 519 in rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/filter.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/filter.rs#L519 

Added line #L519 was not covered by tests

Check warning on line 428 in rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/projection.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/projection.rs#L428 

Added line #L428 was not covered by tests

Check warning on line 439 in rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/projection.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/projection.rs#L439 

Added line #L439 was not covered by tests
View more details on Codecov