Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Add filter flattening rule #9148

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Allow to flatten filter node into internal WrappedSelect. This should allow to execute plans like Aggregate(Filter(Join(...))) as a single grouped wrapper.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (50bdbe7) to head (7237e27).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9148      +/-   ##
==========================================
+ Coverage   83.11%   83.16%   +0.05%     
==========================================
  Files         226      226              
  Lines       79797    80047     +250     
==========================================
+ Hits        66321    66570     +249     
- Misses      13476    13477       +1     
Flag Coverage Δ
cubesql 83.16% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review January 28, 2025 10:48
@mcheshkov mcheshkov requested a review from a team as a code owner January 28, 2025 10:48
@mcheshkov mcheshkov merged commit 92a4b8e into master Jan 28, 2025
72 checks passed
@mcheshkov mcheshkov deleted the filter-flattening branch January 28, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants