Fix connection ordering/meta not syncing across languages.

[benhuson]

Been battling with this issue for a while and was finally able to debug it.

The get_translated_connection_ids() method was incorrectly only returning one ID instead of an array of all translation IDs.

The p2p_get_connections() function returns an array of post IDs.
Using += to concatenate the values return to the $connectionIds array was failing and just returning the first array - according to the PHP documentation:

The + operator returns the right-hand array appended to the left-hand array; for keys that exist in both arrays, the elements from the left-hand array will be used, and the matching elements from the right-hand array will be ignored.

The values returned by p2p_get_connections() were just a non-associative array where the index would start at zero, so each time the arrays were combines with += both arrays had a value at zero index so it just rented the first.

Using array_merge() to combine the returned arrays fixes the issue for me.

[amitkvint]

Seems good for me. Did you test? Want us to test? email me - [email protected]

[benhuson]

I've tested but only using latest versions of WPML and WordPress and this works for me.

If you're able to replicate the issue and confirm the fix that would be useful I guess, just for confirmation.

[laurentdinclaux]

I have not been able to verify, but if the keys are numeric, '+=' may be problematic