Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use prices api for llamma events #634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions apps/main/src/lend/components/ChartOhlcWrapper/LiquidityData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,9 @@ const LiquidityData: React.FC<LiquidityDataProps> = ({ lendControllerData, chain
<>
{coins &&
lendControllerData.map((transaction, index) => (
<TransactionRow key={`${transaction.transaction_hash}-lp-${index}`}>
<LiquidityEvent
href={networks[chainId].scanTxPath(transaction.transaction_hash)}
rel="noopener"
target="_blank"
>
{transaction.deposit !== null && (
<TransactionRow key={`${transaction.txHash}-lp-${index}`}>
<LiquidityEvent href={networks[chainId].scanTxPath(transaction.txHash)} rel="noopener" target="_blank">
{!!transaction.deposit && (
<>
<Box flex flexColumn>
<LiquidityEventTitle>{t`Deposit`}</LiquidityEventTitle>
Expand All @@ -48,15 +44,15 @@ const LiquidityData: React.FC<LiquidityDataProps> = ({ lendControllerData, chain
</LiquidityEventRow>
</>
)}
{transaction.withdrawal !== null && (
{!!transaction.withdrawal && (
<>
<LiquidityEventTitle className="remove">{t`Withdrawal`}</LiquidityEventTitle>
<Box flex flexColumn margin="0 0 0 auto">
{+transaction.withdrawal.amount_collateral !== 0 && (
{+transaction.withdrawal.amountCollateral !== 0 && (
<LiquidityEventRow>
<Chip isBold isNumber>
{formatNumber(transaction.withdrawal.amount_collateral, {
...getFractionDigitsOptions(transaction.withdrawal.amount_collateral, 2),
{formatNumber(transaction.withdrawal.amountCollateral, {
...getFractionDigitsOptions(transaction.withdrawal.amountCollateral, 2),
})}
</Chip>
<LiquiditySymbol>{coins.collateralToken.symbol}</LiquiditySymbol>
Expand All @@ -68,11 +64,11 @@ const LiquidityData: React.FC<LiquidityDataProps> = ({ lendControllerData, chain
/>
</LiquidityEventRow>
)}
{+transaction.withdrawal.amount_borrowed !== 0 && (
{+transaction.withdrawal.amountBorrowed !== 0 && (
<LiquidityEventRow>
<Chip isBold isNumber>
{formatNumber(transaction.withdrawal.amount_borrowed, {
...getFractionDigitsOptions(transaction.withdrawal.amount_borrowed, 2),
{formatNumber(transaction.withdrawal.amountBorrowed, {
...getFractionDigitsOptions(transaction.withdrawal.amountBorrowed, 2),
})}
</Chip>
<LiquiditySymbol>{coins.borrowedToken.symbol}</LiquiditySymbol>
Expand Down
5 changes: 2 additions & 3 deletions apps/main/src/lend/components/ChartOhlcWrapper/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { LlammaControllerEvent } from '@ui/Chart/types'
import { ChainId } from '@/lend/types/lend.types'
import type { LlammaTrade } from '@curvefi/prices-api/llamma'
import type { LlammaTrade, LlammaEvent } from '@curvefi/prices-api/llamma'

export type LendingMarketTokens = {
borrowedToken: {
Expand All @@ -20,7 +19,7 @@ export interface PoolActivityProps {
}

export interface LiquidityDataProps {
lendControllerData: LlammaControllerEvent[]
lendControllerData: LlammaEvent[]
chainId: ChainId
coins: LendingMarketTokens
}
Expand Down
42 changes: 12 additions & 30 deletions apps/main/src/lend/store/createOhlcChartSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ import type {
VolumeData,
LlamaBaselinePriceData,
OraclePriceData,
LlammaControllerApiResponse,
LlammaControllerEvent,
} from 'ui/src/Chart/types'
import type { Address, Chain } from '@curvefi/prices-api'
import { getOracle } from '@curvefi/prices-api/lending'
import { getOHLC, getTrades, type LlammaTrade } from '@curvefi/prices-api/llamma'
import { getOHLC, getTrades, type LlammaTrade, getEvents, type LlammaEvent } from '@curvefi/prices-api/llamma'

import produce from 'immer'

Expand Down Expand Up @@ -52,7 +50,7 @@ type SliceState = {
dataDisabled: boolean
}
lendTradesData: LlammaTrade[]
lendControllerData: LlammaControllerEvent[]
lendControllerData: LlammaEvent[]
activityFetchStatus: FetchingStatus
timeOption: TimeOptions
activityHidden: boolean
Expand Down Expand Up @@ -685,34 +683,18 @@ const createOhlcChart = (set: SetState<State>, get: GetState<State>) => ({
)
}

const controllerEventsRes = await fetch(
`https://prices.curve.fi/v1/lending/llamma_events/${network}/${poolAddress}?page=1&per_page=100`,
)
const controllerEventsData: LlammaControllerApiResponse = await controllerEventsRes.json()

const formattedLiquidityEventsData = controllerEventsData.data.map((data) => ({
...data,
deposit:
data.deposit === null
? null
: {
...data.deposit,
amount: data.deposit.amount,
},
withdrawal:
data.withdrawal === null
? null
: {
...data.withdrawal,
amount_borrowed: data.withdrawal.amount_borrowed,
amount_collateral: data.withdrawal.amount_collateral,
},
}))

if (controllerEventsData) {
const { events } = await getEvents({
endpoint: 'lending',
chain: network as Chain,
llamma: poolAddress as Address,
page: 1,
perPage: 100,
})

if (events) {
set(
produce((state: State) => {
state[sliceKey].lendControllerData = formattedLiquidityEventsData
state[sliceKey].lendControllerData = events
state[sliceKey].activityFetchStatus = 'READY'
}),
)
Expand Down
24 changes: 10 additions & 14 deletions apps/main/src/loan/components/ChartOhlcWrapper/LiquidityData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,9 @@ const LiquidityData: React.FC<LiqudityDataProps> = ({ llammaControllerData, chai
<>
{coins &&
llammaControllerData.map((transaction, index) => (
<TransactionRow key={`${transaction.transaction_hash}-lp-${index}`}>
<LiquidityEvent
href={networks[chainId].scanTxPath(transaction.transaction_hash)}
rel="noopener"
target="_blank"
>
{transaction.deposit !== null && (
<TransactionRow key={`${transaction.txHash}-lp-${index}`}>
<LiquidityEvent href={networks[chainId].scanTxPath(transaction.txHash)} rel="noopener" target="_blank">
{!!transaction.deposit && (
<>
<Box flex flexColumn>
<LiquidityEventTitle>{t`Deposit`}</LiquidityEventTitle>
Expand All @@ -46,15 +42,15 @@ const LiquidityData: React.FC<LiqudityDataProps> = ({ llammaControllerData, chai
</LiquidityEventRow>
</>
)}
{transaction.withdrawal !== null && (
{!!transaction.withdrawal && (
<>
<LiquidityEventTitle className="remove">{t`Withdrawal`}</LiquidityEventTitle>
<Box flex flexColumn margin="0 0 0 auto">
{+transaction.withdrawal.amount_collateral !== 0 && (
{+transaction.withdrawal.amountCollateral !== 0 && (
<LiquidityEventRow>
<Chip isBold isNumber>
{formatNumber(transaction.withdrawal.amount_collateral, {
...getFractionDigitsOptions(transaction.withdrawal.amount_collateral, 2),
{formatNumber(transaction.withdrawal.amountCollateral, {
...getFractionDigitsOptions(transaction.withdrawal.amountCollateral, 2),
})}
</Chip>
<LiquiditySymbol>{coins.collateral.symbol}</LiquiditySymbol>
Expand All @@ -66,11 +62,11 @@ const LiquidityData: React.FC<LiqudityDataProps> = ({ llammaControllerData, chai
/>
</LiquidityEventRow>
)}
{+transaction.withdrawal.amount_borrowed !== 0 && (
{+transaction.withdrawal.amountBorrowed !== 0 && (
<LiquidityEventRow>
<Chip isBold isNumber>
{formatNumber(transaction.withdrawal.amount_borrowed, {
...getFractionDigitsOptions(transaction.withdrawal.amount_borrowed, 2),
{formatNumber(transaction.withdrawal.amountBorrowed, {
...getFractionDigitsOptions(transaction.withdrawal.amountBorrowed, 2),
})}
</Chip>
<LiquiditySymbol>{coins.crvusd.symbol}</LiquiditySymbol>
Expand Down
5 changes: 2 additions & 3 deletions apps/main/src/loan/components/ChartOhlcWrapper/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { LlammaControllerEvent } from '@ui/Chart/types'
import { ChainId, Llamma } from '@/loan/types/loan.types'
import { LlammaTrade } from '@curvefi/prices-api/llamma'
import type { LlammaTrade, LlammaEvent } from '@curvefi/prices-api/llamma'

export type LlammaLiquidityCoins = {
crvusd: {
Expand All @@ -20,7 +19,7 @@ export interface ChartOhlcWrapperProps {
}

export interface LiqudityDataProps {
llammaControllerData: LlammaControllerEvent[]
llammaControllerData: LlammaEvent[]
chainId: ChainId
coins: LlammaLiquidityCoins
}
Expand Down
40 changes: 11 additions & 29 deletions apps/main/src/loan/store/createOhlcChartSlice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ import type {
VolumeData,
LlamaBaselinePriceData,
OraclePriceData,
LlammaControllerApiResponse,
LlammaControllerEvent,
} from 'ui/src/Chart/types'
import type { Address, Chain } from '@curvefi/prices-api'
import { getOHLC, getTrades, type LlammaTrade } from '@curvefi/prices-api/llamma'
import { getOHLC, getTrades, type LlammaTrade, getEvents, type LlammaEvent } from '@curvefi/prices-api/llamma'

import produce from 'immer'

Expand All @@ -26,7 +24,7 @@ type SliceState = {
oraclePriceData: OraclePriceData[]
baselinePriceData: LlamaBaselinePriceData[]
llammaTradesData: LlammaTrade[]
llammaControllerData: LlammaControllerEvent[]
llammaControllerData: LlammaEvent[]
chartFetchStatus: FetchingStatus
activityFetchStatus: FetchingStatus
timeOption: TimeOptions
Expand Down Expand Up @@ -309,34 +307,18 @@ const createOhlcChart = (set: SetState<State>, get: GetState<State>) => ({
)
}

const controllerEventsRes = await fetch(
`https://prices.curve.fi/v1/crvusd/llamma_events/${network}/${poolAddress}?page=1&per_page=100`,
)
const controllerEventsData: LlammaControllerApiResponse = await controllerEventsRes.json()

const formattedLiquidityEventsData = controllerEventsData.data.map((data) => ({
...data,
deposit:
data.deposit === null
? null
: {
...data.deposit,
amount: data.deposit.amount,
},
withdrawal:
data.withdrawal === null
? null
: {
...data.withdrawal,
amount_borrowed: data.withdrawal.amount_borrowed,
amount_collateral: data.withdrawal.amount_collateral,
},
}))
const { events } = await getEvents({
endpoint: 'crvusd',
chain: network as Chain,
llamma: poolAddress as Address,
page: 1,
perPage: 100,
})

if (controllerEventsData) {
if (events) {
set(
produce((state: State) => {
state[sliceKey].llammaControllerData = formattedLiquidityEventsData
state[sliceKey].llammaControllerData = events
state[sliceKey].activityFetchStatus = 'READY'
}),
)
Expand Down
20 changes: 18 additions & 2 deletions packages/prices-api/src/llamma/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,26 @@ import * as Parsers from './parsers'

export type Endpoint = 'crvusd' | 'lending'

export async function getEvents(endpoint: Endpoint, chain: Chain, llamma: string, page: number, options?: Options) {
type GetEventsParams = {
endpoint: Endpoint
chain: Chain
llamma: Address
page?: number
perPage?: number
}

export async function getEvents(
{ endpoint, chain, llamma, page = 1, perPage = 10 }: GetEventsParams,
options?: Options,
) {
const host = getHost(options)
const params = new URLSearchParams({
page: page.toString(),
per_page: perPage.toString(),
})

const resp = await fetch<Responses.GetLlammaEventsResponse>(
`${host}/v1/${endpoint}/llamma_events/${chain}/${llamma}?page=${page}&per_page=10`,
`${host}/v1/${endpoint}/llamma_events/${chain}/${llamma}??${params.toString()}`,
)

return {
Expand Down
19 changes: 0 additions & 19 deletions packages/ui/src/Chart/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,25 +135,6 @@ export interface LpTradeToken {
event_index: number
}

export interface LlammaControllerEvent {
provider: string
deposit: {
amount: string
n1: number
n2: number
} | null
withdrawal: { amount_borrowed: string; amount_collateral: string } | null
block_number: number
timestamp: number
transaction_hash: string
}

export interface LlammaControllerApiResponse {
chain: string
address: string
data: LlammaControllerEvent[]
}

export type LiquidationRange = { value: number; time: UTCTimestamp }

export type LlammaLiquididationRange = {
Expand Down