Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the original comments and also did some modifications #1100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added the original comments and also did some modifications #1100

wants to merge 1 commit into from

Conversation

ar1701
Copy link

@ar1701 ar1701 commented Oct 12, 2024

Issue number- #563

Relevant #563

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

@itsalaidbacklife itsalaidbacklife mentioned this pull request Oct 12, 2024
Closed
4 tasks
Haviles04
Haviles04 reviewed Oct 12, 2024
View reviewed changes
src/router.js
Comment on lines +46 to +51
// Check if the game exists
const gameExists = await gameStore.checkGameExists(gameId);
if (!gameExists) {
return { name: 'Home', query: { error: 'Game does not exist' } };
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels out of scope for this PR

@itsalaidbacklife itsalaidbacklife added enhancement New feature or request hacktoberfest This issue welcomes contributions for Hacktoberfest. hacktoberfest-accepted PR accepted for Hacktoberfest. version-minor An update that warrants a bumping the project's minor version (e.g. 4.0.0 => 4.1.0) labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haviles04 Haviles04 Haviles04 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest This issue welcomes contributions for Hacktoberfest. hacktoberfest-accepted PR accepted for Hacktoberfest. version-minor An update that warrants a bumping the project's minor version (e.g. 4.0.0 => 4.1.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable code splitting at the route level
3 participants
@ar1701 @Haviles04 @itsalaidbacklife