Fix star expression bind for property graph #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
commented
Dec 26, 2024
| @@ -191,23 +191,23 @@ EDGE TABLES ( | |||
| DESTINATION KEY(collegeID) REFERENCES College(id) | |||
| PROPERTIES (classYear) LABEL studiesAt ); | |||
|
|
|||
| query IIII | |||
| query III | |||
There was a problem hiding this comment.
Test cases to verify only registered columns are returned.
dentiny
commented
Dec 26, 2024
| @@ -25,7 +25,7 @@ EDGE TABLES ( | |||
| query IIIIIIIIIII | |||
| -FROM GRAPH_TABLE (snb MATCH (p:Person)) limit 1; | |||
| ---- | |||
| 2010-01-03 23:10:31.499+00 14 Hossein Forouhar male 1984-03-11 77.245.239.11 Firefox 1166 fa;ku;en [email protected] | |||
| 1166 1984-03-11 Firefox 2010-01-03 23:10:31.499+00 [email protected] Hossein male 14 Forouhar 77.245.239.11 fa;ku;en | |||
There was a problem hiding this comment.
NOTICE: This is a behavior change.
- For star expression, duckdb returns columns in the order of they are declared in the
CREATEstatement; - While I'm directly using
columnsin the property graph table: https://github.com/cwida/duckdb-pgq/blob/c380346433db588352999594227f2f8d23be2f49/src/include/duckdb/parser/property_graph_table.hpp#L33 - I think it's ok since they're actually two different SQL statements, so don't need to seek for completely compatibility here; but if it's required, I need to check how property graph table is constructed and why is the ordering difference.
dentiny
force-pushed
the
hjiang/fix-star-expression-bind
branch
from
7af3d90 to
13a430b
Compare
dentiny
force-pushed
the
hjiang/fix-star-expression-bind
branch
4 times, most recently
from
0a876d2 to
13a430b
Compare
dentiny
changed the title
dentiny
changed the title
|
merged the main branch and resolved all conflicts, should be good to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #192
The core idea for this PR is, when a star expression is met, we only include the ones include in the property graph.