Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marx_rl_decon: new script to perform Richardson Lucy deconvolution ... #776

Draft
wants to merge 47 commits into
base: ciao416
Choose a base branch
from

Conversation

kglotfelty
Copy link
Member

…using marx to perform the PSF convolutions.

This needs the bug fix in https://github.com/kglotfelty/marx/tree/fix_offset_input_image to work.

@kglotfelty kglotfelty force-pushed the marx_rl_deconvolution branch from ea26b60 to 4004914 Compare September 22, 2023 11:20
@kglotfelty kglotfelty changed the base branch from main to ciao416 September 22, 2023 11:33
@kglotfelty kglotfelty force-pushed the marx_rl_deconvolution branch from 4004914 to d90a443 Compare October 16, 2023 18:29
@DougBurke
Copy link
Member

Do we think we want to wait until marx is released with this (so go out with it post the December release), or include it now?

@kglotfelty
Copy link
Member Author

I realized that there is a normalization problem somewhere -- I think I know where but I haven't had time to go about fixing. [Basically I believe I need to filter/clip by the FOV file when combining multi-obi, but it has to happen at the right place.]

I'm doubtful it'll be ready for 4.16.0

@DougBurke
Copy link
Member

So, I think it's safest to not hurry for the 4.16.0 release then.

DougBurke and others added 11 commits November 15, 2023 11:31
Unfortunately the API we need is not "standardised" so it is a bit
annoying to support.
initial mamba/micromamba support for check_ciao_version
Remove the README_CIAO_scripts file
…es when DS9 preference file sets default region file format to CIAO
added `xpaset` region formatting specification
…eadme

update tarball build script with the README_CIAO file dropped in 4.16.0
@hamogu
Copy link
Contributor

hamogu commented Nov 29, 2023

The marx source IMAGE also does not work as it is used here, that's not just a simple bug, it's designed to work in a different way (see discussion in Chandra-MARX/marx#50). I think what's needed is a new marx source ("IMAGE-WCS") which makes full use of the WCS information: Chandra-MARX/marx#57

DougBurke and others added 12 commits December 15, 2023 10:21
- the contrib VERSION file is no-longer in contrib/
- we appear to only care about the main "CIAO" package and the
  "contrib" package; the other packages don't have an obvious version
  string - we shall have to wait for an update to sherpa (say) to
  see what happens here
- the ciao-type file no-longer exists, so we ask the system for what
  is in use (now that we have an ARM native version is is easier to
  do)
centroid_map: fix issue with NaNs in input image
map2reg: combine regions using CXCRegion instead of dumping to ascii file
@kglotfelty kglotfelty force-pushed the marx_rl_deconvolution branch from d90a443 to d9ccfd4 Compare March 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants