ci: remove archived technote-space/get-diff-action (cometbft#4007)

This repository has been archived by the owner on Nov 24, 2023. It is
now read-only. See https://github.com/technote-space/get-diff-action

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Sergio Mena <[email protected]>

.github/workflows/build.yml

@@ -4,10 +4,22 @@ name: Build
 # All jobs will pass without running if no *{.go, .mod, .sum} files have been modified
 on:
   pull_request:
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
+      - "!test/**"
   merge_group:
   push:
     branches:
       - main
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
+      - "!test/**"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -32,18 +44,8 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/*.go
-            "!test/"
-            go.mod
-            go.sum
-            Makefile
-
       - name: install
         run: GOOS=${{ matrix.goos }} GOARCH=${{ matrix.goarch }} make build
-        if: "env.GIT_DIFF != ''"
 
   test_abci_cli:
     runs-on: ubuntu-latest
@@ -58,18 +60,10 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/*.go
-            go.mod
-            go.sum
       - name: install
         run: make install_abci
-        if: "env.GIT_DIFF != ''"
       - run: abci/tests/test_cli/test.sh
         shell: bash
-        if: "env.GIT_DIFF != ''"
 
   test_apps:
     runs-on: ubuntu-latest
@@ -84,16 +78,8 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/*.go
-            go.mod
-            go.sum
       - name: install
         run: make install install_abci
-        if: "env.GIT_DIFF != ''"
       - name: test_apps
         run: test/app/test.sh
         shell: bash
-        if: "env.GIT_DIFF != ''"

.github/workflows/codeql.yml

@@ -14,10 +14,15 @@ name: "CodeQL"
 on:
   workflow_dispatch:  # allow running workflow manually
   push:
-    branches: ["main"]
+    branches:
+      - main
+    paths:
+      - "**.go"
   pull_request:
-    # The branches below must be a subset of the branches above
-    branches: ["main"]
+    branches:
+      - main
+    paths:
+      - "**.go"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}

.github/workflows/docs-toc.yml

@@ -2,9 +2,15 @@
 name: Check documentation ToC
 on:
   pull_request:
+    paths:
+      - docs/architecture/**
+      - docs/rfc/**
   push:
     branches:
       - main
+    paths:
+      - docs/architecture/**
+      - docs/rfc/**
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -15,10 +21,4 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            docs/architecture/**
-            docs/rfc/**
       - run: make check-docs-toc
-        if: env.GIT_DIFF

.github/workflows/e2e.yml

@@ -4,12 +4,22 @@ name: e2e
 on:
   workflow_dispatch:  # allow running workflow manually
   pull_request:
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
   merge_group:
   push:
     branches:
       - main
       - v0.3[478].x
       - v[1-9][0-9]?.x
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -31,19 +41,11 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/**.go
-            go.mod
-            go.sum
 
       - name: Build
         working-directory: test/e2e
         run: make -j2 docker runner
-        if: "env.GIT_DIFF != ''"
 
       - name: Run "${{ matrix.group }}"" testnet
         working-directory: test/e2e
         run: ./run-multiple.sh ${{ matrix.group }}.toml
-        if: "env.GIT_DIFF != ''"

.github/workflows/govulncheck.yml

@@ -6,10 +6,22 @@ name: Check for Go vulnerabilities
 # Run `make vulncheck` from the root of the repo to run this workflow locally.
 on:
   pull_request:
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
+      - "!test/**"
   merge_group:
   push:
     branches:
       - main
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
+      - "!test/**"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -25,14 +37,5 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
-          check-latest: true
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/*.go
-            go.mod
-            go.sum
-            Makefile
       - name: govulncheck
         run: make vulncheck
-        if: "env.GIT_DIFF != ''"

.github/workflows/markdown-linter.yml

@@ -8,10 +8,12 @@ on:
       - "**.yml"
       - "**.yaml"
   pull_request:
-    branches: [main]
+    branches:
+      - main
     paths:
       - "**.md"
       - "**.yml"
+      - "**.yaml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}

.github/workflows/tests.yml

@@ -1,10 +1,20 @@
 name: Test
 on:
   pull_request:
+    paths:
+      - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
+      - "!test/**"
   merge_group:
   push:
     paths:
       - "**.go"
+      - go.mod
+      - go.sum
+      - Makefile
+      - "!test/**"
     branches:
       - main
 
@@ -26,15 +36,7 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/**.go
-            "!test/"
-            go.mod
-            go.sum
-            Makefile
+
       - name: Run Go Tests
         run: |
           make test-group-${{ matrix.part }} NUM_SPLIT=20
-        if: env.GIT_DIFF

abci/example/kvstore/helpers.go

@@ -22,7 +22,7 @@ func RandVal() types.ValidatorUpdate {
 // RandVals returns a list of cnt validators for initializing
 // the application. Note that the keys are deterministically
 // derived from the index in the array, while the power is
-// random (Change this if not desired).
+// random (change this if not desired).
 func RandVals(cnt int) []types.ValidatorUpdate {
 	res := make([]types.ValidatorUpdate, cnt)
 	for i := 0; i < cnt; i++ {