Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion mysql-user option in kubectl-moco mysql #473

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Completion mysql-user option in kubectl-moco mysql #473

merged 1 commit into from
Nov 2, 2022

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Nov 1, 2022 •
edited
Loading

ref: #354, #470

Add a completion for --mysql-user(-u) option of kubectl-moco mysql.

$ . <(kubectl-moco completion bash)
$ kubectl-moco mysql -u moco- [tab]
-- completions --
moco-admin     moco-readonly  moco-writable

Signed-off-by: Masayuki Ishii [email protected]

@masa213f masa213f self-assigned this Nov 1, 2022
@masa213f masa213f force-pushed the completion-mysql-user branch from 86ac632 to 88f4aa8 Compare November 2, 2022 00:53
@masa213f masa213f marked this pull request as ready for review November 2, 2022 00:59
@masa213f masa213f requested review from kmdkuk and yamatcha November 2, 2022 01:05
kmdkuk
kmdkuk approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@kmdkuk kmdkuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 235a4b0 into main Nov 2, 2022
@masa213f masa213f deleted the completion-mysql-user branch November 2, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmdkuk kmdkuk kmdkuk approved these changes

@yamatcha yamatcha Awaiting requested review from yamatcha

Assignees

@masa213f masa213f

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masa213f @kmdkuk