Add boot-ip-setter #2767
Open
Add boot-ip-setter #2767
+1,549
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masa213f
force-pushed
the
boot-ip-setter
branch
3 times, most recently
from
d5dcd60 to
6af14e9
Compare
Signed-off-by: Masayuki Ishii <[email protected]>
masa213f
force-pushed
the
boot-ip-setter
branch
from
27f26a4 to
d51b74c
Compare
Signed-off-by: Masayuki Ishii <[email protected]>
masa213f
force-pushed
the
boot-ip-setter
branch
from
e310635 to
9df6bae
Compare
zeroalphat
previously approved these changes
Jan 24, 2025
pkg/boot-ip-setter/main.go
Outdated
| ctx, stop := signal.NotifyContext(context.Background(), syscall.SIGTERM, syscall.SIGINT) | ||
| defer stop() | ||
|
|
||
| logger.Info("hello!", "interface", *flagInterface, "interval", *flagInterval, "listen address", *flagListenAddress) |
There was a problem hiding this comment.
While it might be a matter of preference, I felt it would be better to have a log message indicating that boot-ip-setter has started.
There was a problem hiding this comment.
Thank you. That's right, and it is more polite.
Fixed 8faad74
pkg/boot-ip-setter/main.go
Outdated
| os.Exit(1) | ||
| } | ||
|
|
||
| logger.Info("bye!") |
There was a problem hiding this comment.
Similarly, I felt it would be better to have a log message indicating that boot-ip-setter has finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implementes #2357 .
Add a new daemon
boot-ip-setteron boot servers, and it sets virtual IPs.