Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clearAll method #15

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add a clearAll method #15

merged 2 commits into from
Jul 5, 2024

Conversation

ichiho-ojima
Copy link
Contributor

Thanks to @Kyome22 for providing the foundation of this work in #12!

This PR implements the clearAll method and adds the corresponding unit tests and UI tests.

Fix warnings

Fix WebViewProxyTests

Merged SetUpWebViewAction and SetUpRemakeHandlerAction

Modified the documentation of clearHistory()
@ichiho-ojima ichiho-ojima force-pushed the add-clear-all-method branch 2 times, most recently from 1870b03 to ca6d896 Compare June 14, 2024 15:56
@ichiho-ojima ichiho-ojima force-pushed the add-clear-all-method branch from ca6d896 to 8db61f3 Compare June 18, 2024 08:17
Copy link
Contributor

@Kyome22 Kyome22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Kyome22 Kyome22 merged commit 4708709 into main Jul 5, 2024
2 checks passed
@Kyome22 Kyome22 deleted the add-clear-all-method branch July 5, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants