Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of branch names with slashes #131

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

gowthamkishore3799
Copy link
Contributor

@gowthamkishore3799 gowthamkishore3799 commented Jan 14, 2025

This update addresses issues related to the handling of branch names containing slashes:

  • Branch Names with Slashes: Ensures proper handling of branch names like feature/fix1 without errors.
  • Invalid Branch Names: Introduces a fallback mechanism to default to the main branch while ignoring invalid subpaths.
  • Branch Fetch Failures: Implements a robust fallback logic that reverts to the previous approach, assuming the first name after the repository as the branch name.

@filipchristiansen filipchristiansen requested review from cyclotruc and filipchristiansen and removed request for cyclotruc January 14, 2025 07:22
@filipchristiansen
Copy link
Collaborator

Hi @gowthamkishore3799

Thanks for the changes! Could you please run the following command locally to ensure all pre-commit hooks are installed and executed correctly?

pre-commit install

After that, amend your last commit to trigger the hooks:

git commit --amend --no-edit

Finally, push the changes with:

git push --force-with-lease

This ensures that all necessary checks and formatting are applied. Let me know if you run into any issues! 😊

@filipchristiansen filipchristiansen changed the title Fix: Handling of Branch Names with Slashes fix: handling of branch names with slashes Jan 14, 2025
@gowthamkishore3799
Copy link
Contributor Author

Thanks for the comments @filipchristiansen, changes have been incorporated

@gowthamkishore3799 gowthamkishore3799 marked this pull request as ready for review January 14, 2025 08:38
@filipchristiansen filipchristiansen requested review from filipchristiansen and removed request for cyclotruc January 14, 2025 08:54
Copy link
Collaborator

@filipchristiansen filipchristiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @gowthamkishore3799!

@cyclotruc, can you have a check, and if you think it looks good, you can go ahead and merge.

@filipchristiansen filipchristiansen requested review from cyclotruc and removed request for cyclotruc January 14, 2025 08:55
@cyclotruc cyclotruc merged commit 3ce8e7e into cyclotruc:main Jan 16, 2025
8 checks passed
@gowthamkishore3799 gowthamkishore3799 deleted the fix/branch_name branch January 18, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants