Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on adding a Dockerfile to Polr.
There are already other approaches and I would like to add one more to the discussion.
In this solution I am using an official and community maintained PHP base image instead of installing everything from scratch. While one could manage to build a smaller image and nginx is said to be more performant than apache, I'd opt for the KISS solution that is easy to maintain and leave all special setups to the individual administrator.
Features:
AllowOverride None
is set and the.htaccess
file gets integrated into the apache configuration to increase performance.Try it: https://hub.docker.com/r/wedi42/polr/
I am happy for suggestions to improve the code. Some documentation should be added before a possible merge. I'd just like to discuss this way of solving the task before putting more time into it.