tune learning rate bahdanau-attention #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d2l-bot please rebuild. It was failing earlier due to a broken notebook in master. |
AnirudhDagar
force-pushed
the
hparam_tune
branch
2 times, most recently
from
5680c1f to
f7bcd3b
Compare
|
Job d2l-en/PR-2104/5 is complete. |
|
Is this still WIP while transformer TF needs fix? |
|
Job d2l-en/PR-2104/7 is complete. |
AnirudhDagar
changed the title
|
Job d2l-en/PR-2104/8 is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR should partially fix #2099 but the TF hyperparams/implementation of the section on seq2seq/transformers needs a follow up to fix. I tried different sets of hyperparams for TF but those didn't yield the expected results.
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.