Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: Add create-subset-file #459

Closed
wants to merge 8 commits into from

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Nov 8, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Hope snv tumor only SNV file will be added to v13 data set. Wait for proteomic and miRNA data

What was your approach?

Update create subset file module.

What GitHub issue does your pull request address?

#455

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

biospecimen_id.rds file

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

rds file

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner November 8, 2023 18:15
@jharenza
Copy link
Collaborator

@zzgeng I am not seeing any code changes here - was something missed?

Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some comments on this for tumor only

@jharenza jharenza changed the base branch from dev to download_script_v13 December 15, 2023 21:24
@jharenza
Copy link
Collaborator

closing this in favor of incoming PR

@jharenza jharenza closed this Dec 20, 2023
@jharenza jharenza deleted the zzgeng/subset_for_HOPE branch December 20, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants