Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 disable docker push provenance #248

Merged
merged 1 commit into from
Jun 11, 2024
Merged

🤖 disable docker push provenance #248

merged 1 commit into from
Jun 11, 2024

Conversation

dmiller15
Copy link
Collaborator

Description

Turn off docker push provenance. According to Cavatica and the action release notes, disabling this should result in images being properly displayed on the registry.

Closes https://d3b.atlassian.net/browse/BIXU-3682

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Doing it live I guess

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added bug Something isn't working feature New feature or request bix-dev This issue or pull request is bix-dev work labels Jun 11, 2024
@dmiller15 dmiller15 self-assigned this Jun 11, 2024
Copy link
Collaborator

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, I'll do it live!

@dmiller15 dmiller15 merged commit 11d47b1 into master Jun 11, 2024
1 check passed
@dmiller15 dmiller15 deleted the dm-gha-provenance branch June 11, 2024 19:11
Copy link
Member

@devbyaccident devbyaccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work bug Something isn't working feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants