Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Update PBTA ancestry cohort (3/N) #64

Merged
merged 3 commits into from
May 8, 2024
Merged

Update PBTA ancestry cohort (3/N) #64

merged 3 commits into from
May 8, 2024

Conversation

rjcorb
Copy link
Contributor

@rjcorb rjcorb commented Apr 16, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

Closes #62. This PR addresses minor issues with cohort described in issue #62.

What was your approach?

  • removed parental sample
  • added missing matched tumor histology data for ID BS_M52K86E6
  • add plot group assignment for those samples that were previously NA

What GitHub issue does your pull request address?

#62

Directions for reviewers. Tell potential reviewers what kind of feedback you are

soliciting.

Which areas should receive a particularly close look?

Please review updated code and ensure that all patients in analyses/add-histologies/results/merged_ancestry_histology_data.tsv have an assigned plot group. NOTE: the sample listed above will still have NA for Kids_First_Biospecimen_ID_tumor, but should have an assigned plot group.

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are

ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the
    project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to
    date.
  • The analytical code is documented and contains comments.

@rjcorb rjcorb changed the title Update PBTA ancestry cohort Update PBTA ancestry cohort (3/N) Apr 16, 2024
@rjcorb rjcorb requested review from jharenza and naqvia April 30, 2024 20:36
Base automatically changed from rjcorb/59-repo-run-script to main May 3, 2024 14:11
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rjcorb rjcorb merged commit becc6bf into main May 8, 2024
@rjcorb rjcorb deleted the rjcorb/62-update-cohort branch May 8, 2024 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated analysis: cohort sample updates
2 participants