feat: stream translation titles in feed and post page #4098
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
omBratteng
force-pushed
the
AS-925-kvasir-stream
branch
from
218ee51 to
6343527
Compare
omBratteng
changed the title
omBratteng
requested review from
rebelchris,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
and removed request for
a team
| @@ -24,6 +24,7 @@ | |||
| "date-fns": "^2.25.0", | |||
| "date-fns-tz": "1.2.2", | |||
| "dompurify": "^2.5.4", | |||
| "fetch-event-stream": "^0.1.5", | |||
There was a problem hiding this comment.
You are using this because native EventSource does not allow headers? I would rather use the query param from AI search and native EventSource, wasteful to add dependencies for this.
There was a problem hiding this comment.
Yeah, it's because it doesn't allow headers, think it's a neater solutions than token (don't really like auth tokens in params, even short lived ones 🙈) and language as query param. Package is 730B gzipped, so negligible small imo.
There was a problem hiding this comment.
Can shave it down to 608B gzipped by using events and not their stream wrapper which just adds two headers and checks if response is OK before returning events 🤪
There was a problem hiding this comment.
If anything, I think we should move AI search over to use this as well. Especially now when we're starting to send smart prompts, we might encounter issues with max length of URLs in browsers.
Also because EventSource is kinda "deprecated", no browsers is going to remove it, but it's not getting any new features.
So the package is just for parsing the stream, fetch natively supports streaming.
There was a problem hiding this comment.
Wondering can we just use fetch then?
There was a problem hiding this comment.
So the package name is a bit misleading, it's more a parser than fetch. It exposes events which is the stream parser (608B) then stream (122B) which just wraps around fetch and returns the events parsed stream.
| updatedPost.sharedPost.title = translation.title; | ||
| updatedPost.sharedPost.translation = { title: !!translation.title }; | ||
| } |
There was a problem hiding this comment.
Doesn't this set it wrong in cache?
eg some case the title might not render but we need it for some other field?
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
AS-925
Preview domain
https://as-925-kvasir-stream.preview.app.daily.dev