Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve offset values in progress tracking events parsing #486

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

clarissedmn
Copy link
Contributor

@clarissedmn clarissedmn commented Jan 8, 2025

Description

The precision of Progress tracking events in VAST XML has been improved to preserve the exact offset value in its original format, whether time-based (e.g., 00:00:15.333) or percentage-based (e.g., 60%). The parsing logic has been refined to ensure these values are accurately retained, providing greater reliability and flexibility.

Below is an example showing the improvement:

Capture d’écran 2025-01-08 à 11 39 58

Issue

#485

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@clarissedmn clarissedmn self-assigned this Jan 8, 2025
@dm-ad-sdk dm-ad-sdk bot requested a review from clementFrancon January 8, 2025 10:56
Copy link
Contributor

@clementFrancon clementFrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarissedmn clarissedmn force-pushed the preserve-offset-values branch 3 times, most recently from 147c837 to 955e231 Compare January 9, 2025 16:48
@clarissedmn clarissedmn force-pushed the preserve-offset-values branch 3 times, most recently from aa50487 to 276c1b4 Compare January 23, 2025 16:39
@clarissedmn clarissedmn force-pushed the preserve-offset-values branch from 276c1b4 to e5e1ce3 Compare January 27, 2025 10:05
Copy link
Contributor

@clementFrancon clementFrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarissedmn clarissedmn merged commit e21628b into master Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants