Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include robots.txt in UI and API for handling of web crawlers #2084

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

aaronkanzer
Copy link
Member

@yarikoptic -- per https://dandiarchive.slack.com/archives/GMRLT5RQ8/p1732553458007359 -- includes robots.txt in both UI and backend, per @jwodder suggestion

Cc @jjnesbitt @mvandenburgh

@aaronkanzer
Copy link
Member Author

Adding unit tests currently for backend -- will move out of draft after that is done

@aaronkanzer
Copy link
Member Author

Unite tests added -- moving out of draft

@aaronkanzer aaronkanzer marked this pull request as ready for review November 25, 2024 17:28
dandiapi/urls.py Outdated Show resolved Hide resolved
dandiapi/urls.py Outdated Show resolved Hide resolved
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once these suggestions are applied along with formatting to fix the linting errors, I think this looks good.

dandiapi/api/views/robots.py Outdated Show resolved Hide resolved
dandiapi/api/tests/test_robots.py Outdated Show resolved Hide resolved
@aaronkanzer
Copy link
Member Author

@jjnesbitt thanks for these great suggestions -- you just beat me to pushing the changes 😂

@jjnesbitt jjnesbitt merged commit 7ee26c8 into master Nov 25, 2024
11 checks passed
@jjnesbitt jjnesbitt deleted the ak-robots branch November 25, 2024 19:49
@dandibot
Copy link
Member

dandibot commented Dec 2, 2024

🚀 PR was released in v0.3.111 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants