Upload and AssetBlob garbage collection implementation
#2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
assetblob-upload-gc
branch
from
324610c to
93b64c0
Compare
jjnesbitt
requested changes
Dec 4, 2024
mvandenburgh
force-pushed
the
assetblob-upload-gc
branch
2 times, most recently
from
b3f574a to
10b3cf2
Compare
mvandenburgh
force-pushed
the
assetblob-upload-gc
branch
2 times, most recently
from
4fc142c to
f973fde
Compare
jjnesbitt
requested changes
Jan 24, 2025
mvandenburgh
force-pushed
the
assetblob-upload-gc
branch
from
f973fde to
92785b1
Compare
jjnesbitt
approved these changes
Jan 24, 2025
|
Because this is such a sensitive operation, we'll need to carefully coordinate merging/deploying of this PR. I'll mark it as draft for now so it doesn't get merged by accident. |
mvandenburgh
force-pushed
the
assetblob-upload-gc
branch
2 times, most recently
from
1155480 to
92785b1
Compare
We'd like to run garbage collection manually for the first time, before we start automating it.
|
We discussed this offline, and decided to temporarily disable the garbage collection cron and merge this. Once we've run this manually a few times, we'll enable the automatic cron again. |
|
🚀 PR was released in |
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the design outlined in #2068.