Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun failing test_dandimeta_datacite tests #199

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Rerun failing test_dandimeta_datacite tests #199

merged 1 commit into from
Nov 9, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 9, 2023

It frequently happens that a CI run fails because one instance of test_dandimeta_datacite on one platform got a 422 error. The evidence suggests that this a problem on datacite's end, so this PR causes the test to simply be retried a few times until it succeeds.

@jwodder jwodder added the tests Add or improve existing tests label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c674cd6) 97.38% compared to head (e3a993e) 97.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   97.38%   97.61%   +0.22%     
==========================================
  Files          17       17              
  Lines        1759     1760       +1     
==========================================
+ Hits         1713     1718       +5     
+ Misses         46       42       -4     
Flag Coverage Δ
unittests 97.61% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandischema/tests/test_datacite.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwodder jwodder merged commit 11ed971 into master Nov 9, 2023
75 checks passed
@jwodder jwodder deleted the rerun branch November 9, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants