[WIP] updating life cycle of dandiset #275
Conversation
…i updates (not sure if we should always run the etst, so for now I added skip); updates to to_datacite function
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 97.54% 89.33% -8.22%
==========================================
Files 16 16
Lines 1753 1819 +66
==========================================
- Hits 1710 1625 -85
- Misses 43 194 +151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
|
|
||
| @pytest.mark.skip( | ||
| reason="to not produced too many dois, not sure if we want to keep it as a test" |
There was a problem hiding this comment.
that is because the issue with DOI deletion was not yet addressed on datacite side, right?
then better be mentioned. in the current skip.
Otherwise -- test should be diligent about removing any DOI it created in its life time.
| "assetsSummary": { | ||
| "schemaKey": "AssetsSummary", | ||
| "numberOfBytes": 10, | ||
| "numberOfFiles": 1, | ||
| }, |
There was a problem hiding this comment.
hopefully does not matter but whenever dandiset is created, there is no assets summary yet -- it is done async IIRC, hence
| "assetsSummary": { | |
| "schemaKey": "AssetsSummary", | |
| "numberOfBytes": 10, | |
| "numberOfFiles": 1, | |
| }, |
to_datacitefunction, so it can also work fordraft