Improve _validate_obj_json() in metadata.py and provide utility funcs for validating against JSON schemas
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 97.54% 92.83% -4.71%
==========================================
Files 16 16
Lines 1753 1885 +132
==========================================
+ Hits 1710 1750 +40
- Misses 43 135 +92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
candleindark
force-pushed
the
validate-json
branch
from
d644ac6 to
d1bebc7
Compare
candleindark
force-pushed
the
validate-json
branch
from
d1bebc7 to
6bf8109
Compare
candleindark
changed the title
_validate_obj_json() in metadata.py and provide utility funcs for validating with JSON schema_validate_obj_json() in metadata.py and provide utility funcs for validating against JSON schemas
A util func for validating a metadata instance of a DANDI model against the JSON schema of the model
Additionally, replace relative import with absolute import in `test_util.py` The relative import was referring to an ancestor. See https://docs.astral.sh/ruff/rules/relative-imports/
candleindark
force-pushed
the
validate-json
branch
from
d3703ad to
8f6c760
Compare
Improve type annotations. Make boolean parameter keyword parameter. Make it more correct and robust by using `validate_json()` underneath.
candleindark
force-pushed
the
validate-json
branch
from
8f6c760 to
d4d802f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the following improvement relating to validating metadata instances against a DANDI model's JSON schema.
"$schema"property in a provide schema to determine the appropriate validator classvalidate_json(), to validate a metadata instance of a DANDI model against the JSON schema of the model."schemaVersion"property of the given schema instead of the"schemaVersion"field of a given instance. (A bug fix)_validate_obj_json()using the aforementioned utility functions and provide tests