-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 - oauth2 upgrade #110
base: main
Are you sure you want to change the base?
V2 - oauth2 upgrade #110
Conversation
BREAKING: - remix-auth-oauth2 upgrade
@@ -10,6 +10,7 @@ const config: Config.InitialOptions = { | |||
resetMocks: false, | |||
setupFilesAfterEnv: ["<rootDir>/config/jest/setup.ts"], | |||
testMatch: ["<rootDir>/test/**/*.test.ts"], | |||
transformIgnorePatterns: ["/node_modules/(?!remix-auth-oauth2)/"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2 is ESM so we need to transpile
authorizationEndpoint: `https://${options.domain}/authorize`, | ||
tokenEndpoint: `https://${options.domain}/oauth/token`, | ||
tokenRevocationEndpoint: `https://${options.domain}/oauth/revoke`, | ||
clientId: options.clientID, | ||
clientSecret: options.clientSecret, | ||
callbackURL: options.callbackURL, | ||
redirectURI: options.callbackURL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New keys to support v2 config changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General CI cleanup. Save CI minutes by running all checks before build
Bumped
remix-auth-oauth2
to v2 which caused breaking changes in this package. The shape of theverify
response has changed and appending non-standard custom query string params doesn't appear to be working:https://github.com/sergiodxa/remix-auth-oauth2/blob/e35cd155b8f8ffdbb0f1047f1101f6493d2757f5/src/index.ts#L138 is no longer pulling custom url params
p.s. this contains commits from #109 as well