feat: create home and create vote component #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the home and create vote pages with appropriate features. Also, started centralized error handling components and integrated them there, will be added to other components in the future, as well improved accessibility
danieljancar
added
enhancement
danieljancar
added this to the DEV-Community: Stellar Smart Contracts Challenge (Shipment) milestone
Closed
5 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We appreciate your interest in contributing to our project. As this is your first pull request, please ensure you have followed our Contributing Guidelines, as well as our Git/GitHub workflows. Adhering to these practices helps maintain our project's quality and ease of collaboration. If you're unsure about anything or need some help, don't hesitate to ask. Happy coding!
Gr1ll
requested changes
Aug 6, 2024
| networkPassphrase: Networks.TESTNET, | ||
| }) | ||
| .addOperation( | ||
| contract.call( |
There was a problem hiding this comment.
contract.call(
'create_vote',
nativeToScVal('voteID', { type: 'symbol' }),
nativeToScVal(options, { type: 'vec' }),
nativeToScVal(title, { type: 'string' }),
nativeToScVal(description, { type: 'string' }),
),
voteID is missing, options needs to be set second
| 'create', | ||
| nativeToScVal(title, { type: 'string' }), | ||
| nativeToScVal(description, { type: 'string' }), | ||
| nativeToScVal(options, { type: 'array' }), |
There was a problem hiding this comment.
options current type looks like this:
[
{
"option": "t"
},
{
"option": "t"
}
]
but needs to be like this:
['option1', 'option2']
Gr1ll
approved these changes
Aug 6, 2024
|
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist:
Description
Created the home and create vote pages with appropriate features. Also, started centralized error handling components and integrated them there, will be added to other components in the future, as well improved accessibility
Screenshots (if appropriate):
Screen.Recording.2024-08-06.at.01.53.02.mov
Additional context:
Please try to keep to the clean code approach and try centralising and splitting up components/features if they get to large. 😄