Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add loading spinner when login / logout still undefined #42

Merged
merged 2 commits into from
Aug 11, 2024
Merged

fix: add loading spinner when login / logout still undefined #42

merged 2 commits into from
Aug 11, 2024

Conversation

Gr1ll
Copy link
Collaborator

@Gr1ll Gr1ll commented Aug 11, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING and other relevant documents.

@Gr1ll Gr1ll linked an issue Aug 11, 2024 that may be closed by this pull request
login / logout reset to login for split second when switching tabs #34
Closed
5 tasks
@Gr1ll Gr1ll added bug Something isn't working DSC mandatory Has to be done for DEV-Stellar Challenge labels Aug 11, 2024
@Gr1ll Gr1ll requested a review from danieljancar August 11, 2024 07:23
danieljancar
danieljancar requested changes Aug 11, 2024
View reviewed changes
Copy link
Owner

@danieljancar danieljancar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really bugged, I think we can leave it like before for now. 🙈

@Gr1ll Gr1ll requested a review from danieljancar August 11, 2024 08:49
danieljancar
danieljancar approved these changes Aug 11, 2024
View reviewed changes
Copy link
Owner

@danieljancar danieljancar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now hopefully. 🙈

@danieljancar danieljancar merged commit 7f4a747 into develop Aug 11, 2024
3 checks passed
@Gr1ll Gr1ll deleted the 34-login-logout-reset-to-login-for-split-second-when-switching-tabs branch August 11, 2024 11:29
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released This issue or pr was released in a version label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljancar danieljancar danieljancar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working DSC mandatory Has to be done for DEV-Stellar Challenge released This issue or pr was released in a version
Projects
None yet
Milestone
DEV-Community: Stellar Smart Contract...
Development

Successfully merging this pull request may close these issues.

login / logout reset to login for split second when switching tabs
2 participants
@Gr1ll @danieljancar